This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Conversation
2 tasks
JanStaschulat
suggested changes
Jun 3, 2020
Collaborator
JanStaschulat
left a comment
JanStaschulat
left a comment
There was a problem hiding this comment.
Looks good to me, just update the unit tests.
rclc/test/rclc/test_init.cpp
Outdated
| rc = rclc_support_fini(&support); | ||
| EXPECT_EQ(RCL_RET_OK, rc); | ||
| // test invalid arguments | ||
| rc = rclc_support_init(nullptr, 0, nullptr, &allocator); |
Collaborator
There was a problem hiding this comment.
@pablogs9 use also rclc_support_init_with_options function
rclc/test/rclc/test_init.cpp
Outdated
| rc = rclc_support_init(nullptr, 0, nullptr, &allocator); | ||
| EXPECT_EQ(RCL_RET_INVALID_ARGUMENT, rc); | ||
| rcutils_reset_error(); | ||
| rc = rclc_support_init(&support, 0, nullptr, nullptr); |
Collaborator
There was a problem hiding this comment.
@pablogs9 use also rclc_support_init_with_options function as well.
JanStaschulat
previously approved these changes
Jun 3, 2020
This was referenced Jun 5, 2020
Merged
julionce
reviewed
Jun 8, 2020
Member
Author
|
Changes applied |
julionce
approved these changes
Jun 8, 2020
JanStaschulat
approved these changes
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a convenience function for init with options:
rclc_support_init_with_options.This init function is required when default options from
rcl_get_zero_initialized_init_optionsandrcl_init_options_initare not enough. For example when configuring underlying RMW in micro-ROS.Please let me know your opinions about this feature.